Skip to content

fix(GithubModelImporter): Store both group name and display name - #252

Open
Gabriel-Darbord wants to merge 3 commits into
developfrom
248-group-display-name
Open

Gabriel-Darbord wants to merge 3 commits into
developfrom
248-group-display-name

Conversation

@Gabriel-Darbord

@Gabriel-Darbord Gabriel-Darbord commented Mar 27, 2026 •

Copy link
Copy Markdown
Member

GitHub

GLHGroup's name now corresponds to the login (what's in the address bar), and the new property display_name stores the pretty name found on the group's home page.

GitLab

  • name := path
  • display_name := name

BitBucket

  • display_name := name

BitBucket does not have a third field for groups (in addition to id and name), so the display name is just the same as the name.

Comment on lines -879 to -880
reposResult := self repoApi organizations
getRepositoriesOfOrganization: groupResult name.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like dead code?

@Gabriel-Darbord Gabriel-Darbord linked an issue Mar 27, 2026 that may be closed by this pull request
@Gabriel-Darbord
Gabriel-Darbord marked this pull request as ready for review September 4, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub importer uses group's name instead of login

1 participant