Feature/commitSince accept date - #283
Open
NicolasAnquetil wants to merge 4 commits into
Open
NicolasAnquetil wants to merge 4 commits into
NicolasAnquetil wants to merge 4 commits into
Conversation
added 4 commits
September 1, 2026 17:07
…is in #collection (when #status = 'completed')
badetitou
requested changes
Sep 7, 2026
|
|
||
| withCommitsSince := (someDays isKindOf: DateAndTime) | ||
| ifTrue: [ someDays ] | ||
| withCommitsSince := ((someDays isKindOf: Date) or: (someDays isKindOf: DateAndTime)) |
Member
There was a problem hiding this comment.
Suggested change
| withCommitsSince := ((someDays isKindOf: Date) or: (someDays isKindOf: DateAndTime)) | |
| withCommitsSince := (someDays isKindOf: Date) or: [ someDays isKindOf: DateAndTime ] |
To avoid computing someDays isKindOf: DateAndTime when (someDays isKindOf: Date) is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitModelImporter >> withCommitsSince: accepts a DateAndTime or a Duration and tests
isKindOf: DateAndTime.That seems overly restrictive and we may want to pass a simple Date.
Modified the relevant check