fix(ci): run security audit in the npm/ directory - #11
Merged
Conversation
This repo keeps package.json under npm/ rather than the repo root, so the audit job failed with ENOENT on install. Matches the working-directory convention already used by ci.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security-audit workflow I just added assumed
package.jsonat the repo root, but this repo keeps it undernpm/, so the job failed:Adds
working-directory: npmto the install and audit steps, matching the conventionci.ymlalready uses.audit.jsonis written and read relative to that directory, so it stays consistent.