Skip to content

Use boolean values for curl_setopt options that expect bool type #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyk merged 1 commit into from
Jul 26, 2026
Merged

Use boolean values for curl_setopt options that expect bool type #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Supporting/CommunicationProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@
}
$result['sort'] = $sort;
}
return $result;

Check failure on line 461 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeMismatchReturnNullable Returning $result of type ?array|?array{sort?:array{}|non-empty-list<array{fieldName:mixed,sortOrder:'ascend'|string}>|null,query?:mixed|null|string[][],fieldData:string[]}|?non-empty-array<mixed,mixed> but justifyRequest() is declared to return array (expected returned value to be non-nullable)
}

/**
Expand Down Expand Up @@ -800,11 +800,11 @@
$request = $this->justifyRequest($request);
}
$ch = $this->_createCurlHandle($url);
curl_setopt($ch, CURLOPT_VERBOSE, 0);
curl_setopt($ch, CURLOPT_HEADER, 1);
curl_setopt($ch, CURLOPT_VERBOSE, false);
curl_setopt($ch, CURLOPT_HEADER, true);
curl_setopt($ch, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
if ($methodLower == 'post') {
curl_setopt($ch, CURLOPT_POST, 1);
curl_setopt($ch, CURLOPT_POST, true);
} elseif (in_array($methodLower, ['put', 'patch', 'delete', 'get'], true)) {
curl_setopt($ch, CURLOPT_CUSTOMREQUEST, strtoupper($methodLower));
}
Expand Down Expand Up @@ -976,7 +976,7 @@
*/
public function getCurlInfo($key): mixed
{
return $this->curlInfo[$key];

Check failure on line 979 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeArraySuspiciousNullable Suspicious array access to $this->curlInfo of nullable type ?array|array|null
}

/**
Expand Down Expand Up @@ -1109,7 +1109,7 @@
curl_setopt($ch, CURLOPT_SSLVERSION, CURL_SSLVERSION_DEFAULT);
if ($this->isCertValidating) {
curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 2);
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 1);
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, true);
/* Use the OS native certificate authorities, if possible.
This fixes SSL validation errors if `php.ini` doesn't have [curl] `curl.cainfo`,
set properly of if this PEM file isn't up to date.
Expand All @@ -1121,7 +1121,7 @@
}
} else {
curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 0);
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 0);
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
}
if (!is_null($this->timeout)) {
curl_setopt($ch, CURLOPT_TIMEOUT, $this->timeout);
Expand Down
Loading