Fix PoolAllocator crash on first allocation - #36
Open
Tidenflow wants to merge 2 commits into
Open
Conversation
Initialize the intrusive free-list head and return nullptr when no recycled pool chunks are available, preserving lazy O(1) pool initialization.
Return zero after every allocator benchmark completes successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StackLinkedList::headtonullptr.nullptrwhenStackLinkedList::pop()is called on an empty list.Problem
After the PoolAllocator initialization was changed to use offset-based lazy allocation, its free list can be empty during the first allocation.
PoolAllocator::Allocate()expectspop()to returnnullptrin that case, butStackLinkedList::pop()dereferencesheadunconditionally. This causes an access violation before the allocator can fall back to allocating a new chunk using the offset.Verification
Built and ran the project with MinGW on Windows: