Skip to content

Accept CMS OCTET STRING encoding for SpcIndirectDataContent - #506

Merged
mtrojnar merged 1 commit into
mtrojnar:masterfrom
olszomal:fix-cms-octet-string
Sep 24, 2026
Merged

mtrojnar merged 1 commit into
mtrojnar:masterfrom
olszomal:fix-cms-octet-string

Conversation

@olszomal

@olszomal olszomal commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Pull Request Type

  • Bug fix
  • New feature
  • Code style / formatting / renaming
  • Refactoring (no functional or API changes)
  • Build / CI related changes
  • Documentation
  • Other (please describe):

Related Issue

Fixes #505

Current Behavior

SpcIndirectDataContent decoding accepts only ASN.1 SEQUENCE values.

New Behavior

Accept both directly encoded ASN.1 SEQUENCE content and CMS OCTET STRING-wrapped content, as described in RFC 5652 section 5.2.1.

Scope of Changes

Update asn1_type_get_indirect_data_content() to handle both PKCS#7 and CMS representations.

Testing

  • Existing tests
  • New tests added
  • Manual testing

Additional Notes

License Declaration

  • I hereby agree to license my contribution under the project's license.

@olszomal
olszomal force-pushed the fix-cms-octet-string branch from 3d0821a to 9593bb1 Compare September 23, 2026 12:54
@mtrojnar
mtrojnar merged commit e5c9577 into mtrojnar:master Sep 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.14 rejects install4j-signed Windows executables that Windows accepts

2 participants