fix(realtime): accept GA WebRTC signaling - #11778
Open
localai-org-maint-bot wants to merge 1 commit into
Open
Conversation
OpenAI GA clients send multipart or raw SDP requests. They expect a bare SDP answer. LocalAI only accepted its legacy JSON envelope, so signaling failed before media setup. Keep the JSON contract for existing clients. Accept both GA request shapes and choose the matching response format. Assisted-by: Codex:gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the OpenAI GA WebRTC signaling formats to
/v1/realtime/calls:multipart/form-datawithsdpand JSONsessionfieldsapplication/sdpwith the model in the query stringapplication/sdpanswer for both GA formatsCloses #11776
Notes for Reviewers
The request decoder and response writer have focused Ginkgo coverage. The existing JSON browser client remains unchanged.
Verification:
go test ./core/http/endpoints/openaigo vet ./core/http/endpoints/openaigit diff --checkSigned commits