Repository navigation
test(ui): stub the pin routes in the add-on e2e fixtures - #12882
Merged
Merged
Conversation
mudler
force-pushed
the
fix/addons-e2e-pin-stubs
branch
from
October 24, 2026 19:55
677acfa to
4875f90
Compare
The add-on owner now runs as its own workload. With no owner running the server reports the add-ons feature off and answers 5xx on /api/addons/builtin and /api/addons/pins. The add-on pages are gated on that flag, and the navigation shell calls both routes, which the browser logs as failed requests. Specs that draw add-on pages assert no console errors, so they failed on master. Stub those routes on the browser context: the feature flag is switched on with the server's other flags kept, and the pin routes answer with an empty set. A spec's own page routes still take precedence. Studio's old-address and 404 specs call the same stub, since they expect add-ons to be on. The server behaviour is unchanged. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
force-pushed
the
fix/addons-e2e-pin-stubs
branch
from
October 24, 2026 20:42
4875f90 to
a12555a
Compare
mudler
marked this pull request as ready for review
October 24, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI E2E job fails on
mastersince #12867 (the add-on owner runs as its own workload). With no owner running, the server reports the add-ons feature off and answers 5xx on/api/addons/builtinand/api/addons/pins, which is the intended behaviour. The add-on pages are gated on that flag, the navigation shell calls both routes, and the browser logs each failed request. Specs that draw add-on pages assert no console errors, so they fail.This PR stubs those routes on the browser context in the shared add-on fixtures, the same way
addon-navigationalready does. The stubs switch the add-ons feature on (other flags keep the server's values) and answer the pin routes with an empty set. A spec's own page routes still take precedence. The server behaviour is unchanged.Verification
addon-navigation"add-ons off" tests: left as they were. They fail onmaster's fixtures too, so they are not part of this change.🤖 Generated with Claude Code