@W-23751548: Pack Node bindings as unscoped dataweave-native platform packages - #168
Open
mlischetti wants to merge 15 commits into
Open
@W-23751548: Pack Node bindings as unscoped dataweave-native platform packages#168mlischetti wants to merge 15 commits into
mlischetti wants to merge 15 commits into
Conversation
cmd /c with a quoted absolute path made npm look under cwd for a literal quoted directory. Pass npm pack args separately. Drop the accidental SDD task report from the branch.
Windows join() uses backslashes, so tests that asserted POSIX /opt/plat/dwlib.so never matched existsSync and failed nodeTest.
mlischetti
changed the title
Use require.resolve so path resolution does not dlopen the addon. Cross-link SUPPORTED_NATIVE_PACKAGES with the pack script list.
Backslash continuation is not portable to cmd.exe or PowerShell.
svacas
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare Node artifacts for a later npm promote (PDK-style unscoped name, no publish in this PR).
dataweave-nativeplus optionaldataweave-native-{linux-x64,win32-x64,darwin-arm64}dwlibnext to the resolved addonbuildNodePackageemits versioned tgz (nativeVersion); CI uploads platform tgz per OS and meta from Linux onlynpm install dataweave-native; published platforms exclude darwin-x64Test plan
./gradlew native-lib:nodePackTest -PskipNodeTests=falsecd native-lib/node && npx vitest run --project unit tests/unit/addon-path.test.ts tests/unit/utils.test.tsmain.ymlNode legs: three platform tgz + one meta on Linux