Refactor Audio Functions to use new parser - #5346
Open
iManGaaX wants to merge 9 commits into
Open
Conversation
FileEX
requested changes
Sep 9, 2026
Comment out audio function bindings for future reference.
FileEX
requested changes
Sep 9, 2026
FileEX
requested changes
Sep 9, 2026
| return newData; | ||
| } | ||
|
|
||
| static bool IsSoundURL(const std::string& soundPath) |
FileEX
requested changes
Sep 9, 2026
| bankIndex = *bankValue; | ||
| else if (containerIndex == AUDIO_LOOKUP_RADIO) | ||
| bankIndex = static_cast<int>(*std::get_if<eRadioStreamIndex>(&bank)); | ||
| else if (auto* radioIndex = std::get_if<eRadioStreamIndex>(&bank)) |
Member
There was a problem hiding this comment.
containerIndex == AUDIO_LOOKUP_RADIO and std::get_if
FileEX
requested changes
Sep 9, 2026
| { | ||
| using ResultType = std::variant<std::unordered_map<int, float>, bool>; | ||
|
|
||
| if (!IsValidFFTBandCount(length, bands.value_or(0))) |
Member
There was a problem hiding this comment.
Instead of repeating bands.value_or(0), define it once in a variable.
| fftData = ProcessFFTData(std::move(fftData), length, bands.value_or(0)); | ||
|
|
||
| const int size = bands.value_or(0) == 0 ? length / 2 : bands.value_or(0) - 1; | ||
| std::unordered_map<int, float> data; |
| if (!waveData) | ||
| return ResultType{false}; | ||
|
|
||
| std::unordered_map<int, float> data; |
FileEX
reviewed
Sep 9, 2026
Comment on lines
+16
to
+20
| #include <array> | ||
| #include <cctype> | ||
| #include <cmath> | ||
| #include <memory> | ||
| #include <ranges> |
Member
There was a problem hiding this comment.
Do you really need <memory> and <cctype>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.