Skip to content

fixed the issue with mismatched dark mode palette colors #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ash-wright123 merged 2 commits into from
Sep 17, 2026
Merged

fixed the issue with mismatched dark mode palette colors #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d15f061
fixed the issue with mismatched dark mode palette colors
ash-wright123 Sep 17, 2026
80d9107
fix: fix mismatch in kyper and mui dark mode colors
ash-wright123 Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions src/ConnectedTokenProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,33 @@ export const ConnectedTokenProvider = ({ children }: Props): React.ReactNode =>
useMUIStandardSpacing: true,
})

const kyperTokenOverrides = {
Color: {
Brand100: isDarkModeEnabled ? mxTheme.palette.primary[800] : mxTheme.palette.primary[100],
Brand200: mxTheme.palette.primary.light,
Brand300: mxTheme.palette.primary.main,
Brand400: mxTheme.palette.primary.dark,
Brand500: isDarkModeEnabled ? mxTheme.palette.primary[50] : mxTheme.palette.primary[900],
Primary100: isDarkModeEnabled ? mxTheme.palette.primary[800] : mxTheme.palette.primary[100],
Primary200: mxTheme.palette.primary.light,
Primary300: mxTheme.palette.primary.main,
Primary400: mxTheme.palette.primary.dark,
Primary500: isDarkModeEnabled ? mxTheme.palette.primary[50] : mxTheme.palette.primary[900],
},
}
const kyperTokenOverrides = React.useMemo(
() => ({
Color: {
Brand100: isDarkModeEnabled ? mxTheme.palette.primary[800] : mxTheme.palette.primary[100],
Brand200: mxTheme.palette.primary.light,
Brand300: mxTheme.palette.primary.main,
Brand400: mxTheme.palette.primary.dark,
Brand500: isDarkModeEnabled ? mxTheme.palette.primary[50] : mxTheme.palette.primary[900],
Primary100: isDarkModeEnabled ? mxTheme.palette.primary[800] : mxTheme.palette.primary[100],
Primary200: mxTheme.palette.primary.light,
Primary300: mxTheme.palette.primary.main,
Primary400: mxTheme.palette.primary.dark,
Primary500: isDarkModeEnabled ? mxTheme.palette.primary[50] : mxTheme.palette.primary[900],
},
// MXUI owns our surface colors. Kyper's own background tokens disagree
// with it (#1F2329 vs #000000 in dark mode), so views still reading from
// Kyper paint a different color than MUI surfaces. Map these the same way the Color tokens above are mapped, so
// both systems agree while the Kyper migration finishes.
BackgroundColor: {
Body: mxTheme.palette.background.default,
Container: mxTheme.palette.background.paper,
},
}),
// TokenProvider keys a useEffect off this object's identity, so it has to
// be stable across renders.
[isDarkModeEnabled, mxTheme.palette.primary, mxTheme.palette.background],
)

return (
<TokenProvider
Expand Down
Loading