Skip to content

fix: fix alignment of chevron icon in some links #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesrisenmay-mx merged 1 commit into from
Sep 18, 2026
Merged

fix: fix alignment of chevron icon in some links #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions src/views/disclosure/Interstitial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ export const VIEWS = {
PRIVACY_POLICY: 'privacy_policy',
}

const linkStackProps = {
component: Link,
direction: 'row',
spacing: 0.5,
underline: 'hover',
variant: 'body2',
}

export const DisclosureInterstitial = React.forwardRef((props, interstitialNavRef) => {
const { handleGoBack, scrollToTop } = props
useAnalyticsPath(...PageviewInfo.CONNECT_DISCLOSURE)
Expand Down Expand Up @@ -167,20 +175,18 @@ export const DisclosureInterstitial = React.forwardRef((props, interstitialNavRe
</Stack>
</Stack>
</SlideDown>
<Stack direction={'column'}>
<Link
className={styles.link}
<Stack className={styles.linkContainer} spacing={2}>
<Stack
data-test="data-requested-button"
onClick={() => {
setCurrentView(VIEWS.DATA_REQUESTED)
}}
variant="subtitle2"
{...linkStackProps}
>
{__('Data requested')}
<div>{__('Data requested')}</div>
<Icon name="chevron_right" size={16} />
</Link>
<Link
className={styles.link}
</Stack>
<Stack
data-test="privacy-policy-button"
onClick={() => {
if (showExternalLinkPopup) {
Expand All @@ -195,12 +201,11 @@ export const DisclosureInterstitial = React.forwardRef((props, interstitialNavRe
goToUrlLink(privacyUrl, true)
}
}}
variant="subtitle2"
{...linkStackProps}
>
{_p('connect/disclosure/policy/link', 'MX Privacy Policy')}

<div>{_p('connect/disclosure/policy/link', 'MX Privacy Policy')}</div>
<Icon name="chevron_right" size={16} />
</Link>
</Stack>
</Stack>
</Fragment>
)
Expand Down
4 changes: 1 addition & 3 deletions src/views/disclosure/Interstitial.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
margin-left: var(--spacing-4-point-5);
}

.link:global(.MuiLink-root) {
gap: var(--spacing-point-5);
.linkContainer {
margin-left: var(--spacing-4);
margin-top: var(--spacing-2);
width: fit-content;
}
Loading