Skip to content

migrated selection boxes to radio buttons #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ash-wright123 merged 2 commits into from
Sep 21, 2026
+39 −29
Merged

migrated selection boxes to radio buttons #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aaff08
migrated selection boxes to radio buttons
ash-wright123 Sep 21, 2026
cbfbda9
fix: fix overlapping selection boxes
ash-wright123 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 38 additions & 23 deletions src/views/microdeposits/AccountInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,16 @@ import PropTypes from 'prop-types'
import _isEmpty from 'lodash/isEmpty'

import { Icon, Text } from '@mxenabled/mxui'
import { TextField, SelectionBox } from 'src/privacy/input'
import { Button, RadioGroup, FormControl, FormLabel, Stack } from '@mui/material'
import { TextField } from 'src/privacy/input'
import {
Button,
FormControl,
FormControlLabel,
FormLabel,
Radio,
RadioGroup,
Stack,
} from '@mui/material'

import useAnalyticsPath from 'src/hooks/useAnalyticsPath'

Expand Down Expand Up @@ -85,30 +93,37 @@ export const AccountInfo = (props) => {
<SlideDown delay={getNextDelay()}>
<FormControl className={styles.formControl} component="fieldset">
<FormLabel component="legend">{__('Account type')}</FormLabel>
<RadioGroup className={styles.radioGroup} name="row-radio-buttons-group" row={true}>
<SelectionBox
autoFocus={
focus === AccountFields.ACCOUNT_TYPE &&
accountType === ReadableAccountTypes.CHECKING
<RadioGroup
className={styles.radioGroup}
name="accountType"
onChange={(e) => setAccountType(Number(e.target.value))}
value={accountType}
>
<FormControlLabel
control={
<Radio
autoFocus={
focus === AccountFields.ACCOUNT_TYPE &&
accountType === ReadableAccountTypes.CHECKING
}
size="small"
/>
}
id={AccountTypeLabels[ReadableAccountTypes.CHECKING]}
message={AccountTypeLabels[ReadableAccountTypes.CHECKING]}
name="accountType"
onChange={() => setAccountType(ReadableAccountTypes.CHECKING)}
selected={accountType === ReadableAccountTypes.CHECKING}
value={AccountTypeLabels[ReadableAccountTypes.CHECKING]}
label={AccountTypeLabels[ReadableAccountTypes.CHECKING]}
value={ReadableAccountTypes.CHECKING}
/>
<SelectionBox
autoFocus={
focus === AccountFields.ACCOUNT_TYPE &&
accountType === ReadableAccountTypes.SAVINGS
<FormControlLabel
control={
<Radio
autoFocus={
focus === AccountFields.ACCOUNT_TYPE &&
accountType === ReadableAccountTypes.SAVINGS
}
size="small"
/>
}
id={AccountTypeLabels[ReadableAccountTypes.SAVINGS]}
message={AccountTypeLabels[ReadableAccountTypes.SAVINGS]}
name="accountType"
onChange={() => setAccountType(ReadableAccountTypes.SAVINGS)}
selected={accountType === ReadableAccountTypes.SAVINGS}
value={AccountTypeLabels[ReadableAccountTypes.SAVINGS]}
label={AccountTypeLabels[ReadableAccountTypes.SAVINGS]}
value={ReadableAccountTypes.SAVINGS}
/>
</RadioGroup>
</FormControl>
Expand Down
7 changes: 1 addition & 6 deletions src/views/microdeposits/AccountInfo.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,8 @@
}

.radioGroup:global(.MuiFormGroup-root) {
justify-content: space-between;
margin-top: var(--spacing-1);
padding-bottom: var(--spacing-2);
}

.radioGroup > :global(.ph-no-capture) {
width: 48%;
padding-bottom: var(--spacing-4);
}

.button:global(.MuiButton-root) {
Expand Down
Loading