Skip to content

fix: replacing kyper token provider with a stub - #401

Merged
wesrisenmay-mx merged 1 commit into
masterfrom
wes/CT-2416/TokenProviderStub
Sep 23, 2026
Merged

fix: replacing kyper token provider with a stub#401
wesrisenmay-mx merged 1 commit into
masterfrom
wes/CT-2416/TokenProviderStub

Conversation

@wesrisenmay-mx

@wesrisenmay-mx wesrisenmay-mx commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@wesrisenmay-mx
wesrisenmay-mx marked this pull request as draft September 23, 2026 18:22
@codingLogan

codingLogan commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Do we have a measure of how much this changes our bundle size?

@ash-wright123

ash-wright123 commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Will this be able to be imported to connections? Or will we have to do something similar over there?

@wesrisenmay-mx

wesrisenmay-mx commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator Author

Do we have a measure of how much this changes our bundle size?

It should be negligible in either direction. It's mostly about not getting errors based on kyper token provider relying on specific versions of React, and allowing us to make the changes slowly over time.

@wesrisenmay-mx

wesrisenmay-mx commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Will this be able to be imported to connections? Or will we have to do something similar over there?

I would just do the same thing in the mx connect widget. I could export it from here, but pretty soon I'm going to import the package into the connect widget, and then it won't matter.

@wesrisenmay-mx
wesrisenmay-mx marked this pull request as ready for review September 23, 2026 20:22
codingLogan
codingLogan approved these changes Sep 23, 2026
View reviewed changes

@codingLogan codingLogan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An incremental step in the freedom direction feels good.

@wesrisenmay-mx
wesrisenmay-mx merged commit 98531f0 into master Sep 23, 2026
7 checks passed
@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.40.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codingLogan codingLogan codingLogan approved these changes
@ash-wright123 ash-wright123 Awaiting requested review from ash-wright123 ash-wright123 is a code owner
@mwclemy mwclemy Awaiting requested review from mwclemy mwclemy is a code owner
@Jameson13B Jameson13B Awaiting requested review from Jameson13B Jameson13B is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wesrisenmay-mx @codingLogan @ash-wright123