fix packed UI and run release on one runner - #74
Merged
jkandasa merged 1 commit intoSep 18, 2026
Merged
Conversation
Split jobs only existed to pass artifacts between VMs. That overwrite web-console/build with the Vite source index.html and shipped a binary whose UI never loaded. Build, pack, release, and push images on the same host. Fail pack if index.html still points at /src/index.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The development binary served the Vite source page (
<script type=\"module\" src=\"/src/index.js\">) instead of the production bundle. After checkout,web-console/index.htmlalready exists; the artifact flatten treated that as a misplaced build and moved the source tree overweb-console/build. Pack then embedded that mix.This change:
pack_web_consolefail ifbuild/index.htmlstill references/src/index.js.mycontroller-org/server.developmenttag to${{ github.sha }}.After merge, on a machine that already ran the bad binary: clear
web.web_directory(or do not point it at the repoweb-console/), delete{data}/internal/web_console, and restart with the new build.Test plan
mainrelease run is a single Release job and stays green./assets/index-*.js, not/src/index.js.developmenttag SHA matches the merge commit.