add macOS archives and a single multi-arch image tag - #75
Merged
Merged
Conversation
Cross-compile darwin/amd64 and darwin/arm64. Darwin serial uses go.bug.st/serial so CGO is not required; linux and windows still use tarm/serial. Container publish is one buildx push per image so only :VERSION exists. Dockerfile platform ARGs have no defaults so BuildKit selects linux-amd64, linux-arm64, linux-armv7, linux-armv6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
darwin/amd64) and Apple Silicon (darwin/arm64).tarm/serialwithCGO_ENABLED=0. Linux/Windows still use tarm; Darwin usesgo.bug.st/serial(8N1, flush = reset in/out buffers).buildx --platform linux/amd64,linux/arm64,linux/arm/v7,linux/arm/v6 --tag :VERSION --push. No:VERSION-linux-amd64(etc.) tags.TARGETOS/TARGETARCH/TARGETVARIANThave no defaults, so BuildKit copies the matching host binary.Test plan
mainrelease includesmycontroller-*-darwin-amd64.tar.gzand*-darwin-arm64.tar.gz.docker pull ghcr.io/mycontroller-org/server:2.3.0-develis multi-arch; no new-linux-*tags.