fix: make JobLogger thread-safe - #41
Merged
Merged
Conversation
Serialize writes to the StreamWriter with a lock, and guard against writes after Dispose to prevent ObjectDisposedException. Add concurrency tests and mark code-review item #2 as done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes code-review item #2 — Fix
JobLoggerthread-safety.JobLoggerwraps aStreamWriter, which is not thread-safe. ConcurrentLog<TState>calls from multiple background services could interleave/corrupt log lines, and a dispose racing a write could throwObjectDisposedException.Changes
src/ArmRipper.Core/Infrastructure/JobLogger.cslock (_writeLock)inLog<TState>.Dispose/DisposeAsyncbefore flushing/closing._disposedguard so late writes after dispose are no-ops instead of throwing.DisposeAsyncnow delegates to the lockedDispose(avoids holding a Monitor across awaits).tests/ArmRipper.Core.Tests/JobLoggerTests.cs(new)ConcurrentLogs_AllLinesPreserved— 200 parallel writes; asserts every line is intact and no interleaving/corruption.Log_AfterDispose_DoesNotThrow.docs/code-review/README.md+02-joblogger-thread-safety.md— mark refactor: add consistent DiagnosticSource categories for all logging … #2 as Done (Todo 25 / Done 11).Verification
dotnet build— 0 warnings, 0 errors.master— confirmed by running the identical suite on a clean master worktree (identical failure sets, zero new failures).Notes
JobLoggeris currently unused by production code (the pipeline routes through the already-thread-safeJobFileLoggerProvider), but the review item explicitly required hardening it, so it is now safe to use.