Skip to content

[0.60.4] Keep Claude account labels private - #555

Open
Finesssee wants to merge 1 commit into
mainfrom
codex/port-0.60.4-claude-privacy
Open

Finesssee wants to merge 1 commit into
mainfrom
codex/port-0.60.4-claude-privacy

Conversation

@Finesssee

@Finesssee Finesssee commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Port the privacy behavior from upstream f696a1dc89599cf91110b0bec0a8906f4439c2c3.
  • Use stable localized Account N labels for saved Claude account rows when Hide Personal Info is enabled.
  • Keep matching tooltips redacted and keep labels attached to the same account when the source list reorders.
  • Keep organization details hidden with the account identity and preserve the existing visible-mode behavior.

Validation

  • pnpm exec tsc --noEmit --pretty false
  • pnpm test --run src/components/ClaudeAccountsMenu.test.tsx src/surfaces/settings/providers/sections/credentials/ClaudeSwapAccountsSection.test.tsx (13 passed)
  • pnpm exec oxlint src/components/ClaudeAccountsMenu.tsx src/components/claudeAccountDisplay.ts src/components/ClaudeAccountsMenu.test.tsx
  • git diff --check

This PR is intentionally scoped to the Windows tray account switcher and is ready for review. It is not merged.

Summary by CodeRabbit

  • Bug Fixes
    • Improved privacy mode in the Claude account menu by displaying stable, localized account labels instead of masked email addresses.
    • Added matching redacted tooltips for private account entries.
    • Account labels now remain consistent when the account list is reordered.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c85a4e26-b7df-4481-9ebb-cd74e9c296f7

📥 Commits

Reviewing files that changed from the base of the PR and between 10e3b09 and 7af30ed.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • apps/desktop-tauri/src/components/ClaudeAccountsMenu.test.tsx
  • apps/desktop-tauri/src/components/ClaudeAccountsMenu.tsx
  • apps/desktop-tauri/src/components/claudeAccountDisplay.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

Claude account rows now use stable, localized Account N labels and matching tooltips when Hide Personal Info is enabled. Ordinals derive from sorted account IDs, and tests verify stability after account-list reordering.

Changes

Claude account labels

Layer / File(s) Summary
Account display helpers
apps/desktop-tauri/src/components/claudeAccountDisplay.ts
Adds helpers that assign stable ordinals from unique sorted account IDs and return redacted or email-based labels and tooltips.
Menu integration and validation
apps/desktop-tauri/src/components/ClaudeAccountsMenu.tsx, apps/desktop-tauri/src/components/ClaudeAccountsMenu.test.tsx, CHANGELOG.md
The menu uses the new helpers. Tests verify localized masked labels, matching tooltips, and stability after account reordering. The changelog records the fix.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: keeping Claude account labels private. It is concise and directly related to the privacy behavior described in the pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant