Skip to content

[0.64.1] Retire the Crof provider safely #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Finesssee wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[0.64.1] Retire the Crof provider safely #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
299aadb
Retire Crof provider safely
Finesssee Sep 22, 2026
1ccb4de
Canonicalize loaded provider identifiers
Finesssee Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/desktop-tauri/src/components/providers/icons/ProviderIcon-crof.svg
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions apps/desktop-tauri/src/components/providers/providerIcons.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,8 @@ describe("provider icon registry", () => {
expect(PROVIDER_ICON_REGISTRY[id], id).toBeDefined();
}
});

it("does not expose the retired Crof provider", () => {
expect(PROVIDER_ICON_REGISTRY).not.toHaveProperty("crof");
});
});
3 changes: 0 additions & 3 deletions apps/desktop-tauri/src/components/providers/providerIcons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import coderabbit from "./icons/ProviderIcon-coderabbit.svg?raw";
import codex from "./icons/ProviderIcon-codex.svg?raw";
import commandcode from "./icons/ProviderIcon-commandcode.svg?raw";
import copilot from "./icons/ProviderIcon-copilot.svg?raw";
import crof from "./icons/ProviderIcon-crof.svg?raw";
import crossmodel from "./icons/ProviderIcon-crossmodel.svg?raw";
import cursor from "./icons/ProviderIcon-cursor.svg?raw";
import deepgram from "./icons/ProviderIcon-deepgram.svg?raw";
Expand Down Expand Up @@ -102,7 +101,6 @@ const RAW: Record<string, string> = {
codex: tint(codex),
commandcode: tint(commandcode),
copilot: tint(copilot),
crof: tint(crof),
crossmodel: tint(crossmodel),
cursor: tint(cursor),
deepgram: tint(deepgram),
Expand Down Expand Up @@ -218,7 +216,6 @@ export const PROVIDER_ICON_REGISTRY: Record<string, ProviderIcon> = {
mimo: { id: "mimo", brandColor: "#ff6900", fallbackLetter: "M", svgPath: RAW.mimo },
doubao: { id: "doubao", brandColor: "#2563eb", fallbackLetter: "D", svgPath: RAW.doubao },
commandcode: { id: "commandcode", brandColor: "#44ff00", fallbackLetter: "C", svgPath: RAW.commandcode },
crof: { id: "crof", brandColor: "#7c3aed", fallbackLetter: "C", svgPath: RAW.crof },
crossmodel: { id: "crossmodel", brandColor: "#c084fc", fallbackLetter: "X", svgPath: RAW.crossmodel },
qoder: { id: "qoder", brandColor: "#2563eb", fallbackLetter: "Q", svgPath: RAW.qoder },
replicate: { id: "replicate", brandColor: "#000000", fallbackLetter: "R", svgPath: RAW.replicate },
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop-tauri/src/surfaces/TrayPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import {
const HAS_DASHBOARD = new Set([
"abacus", "alibaba", "alibabatokenplan", "amp", "augment",
"azureopenai", "bedrock", "claude", "codex", "codebuff",
"aiand", "commandcode", "copilot", "crof", "crossmodel", "cursor", "deepgram", "deepinfra", "deepseek", "zenmux", "clinepass", "longcat", "neuralwatt", "zoommate",
"aiand", "commandcode", "copilot", "crossmodel", "cursor", "deepgram", "deepinfra", "deepseek", "zenmux", "clinepass", "longcat", "neuralwatt", "zoommate",
"doubao", "elevenlabs", "factory", "gemini", "grok", "groq",
"infini", "jetbrains", "kilo", "kimi", "kimik2", "kiro", "manus", "replicate",
"mimo", "minimax", "mistral", "nanogpt", "notion", "ollama", "openaiapi",
Expand Down
1 change: 0 additions & 1 deletion apps/desktop-tauri/src/surfaces/settings/tabs/ProvidersTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ function providerSourceHintShort(
case "clinepass":
case "neuralwatt":
case "doubao":
case "crof":
case "stepfun":
case "venice":
case "openaiapi":
Expand Down
1 change: 0 additions & 1 deletion apps/desktop-tauri/src/test/providerCatalog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export const TEST_PROVIDER_CATALOG: Array<[string, string]> = [
["mimo", "Xiaomi MiMo"],
["doubao", "Doubao"],
["commandcode", "Command Code"],
["crof", "Crof"],
["stepfun", "StepFun"],
["venice", "Venice"],
["openaiapi", "OpenAI API"],
Expand Down
3 changes: 0 additions & 3 deletions rust/assets/icons/ProviderIcon-crof.svg
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions rust/src/cli/serve/dashboard/icons.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ static ICONS: &[(&str, &[u8])] = &[
"ProviderIcon-copilot",
include_bytes!("icons/ProviderIcon-copilot.svg"),
),
(
"ProviderIcon-crof",
include_bytes!("icons/ProviderIcon-crof.svg"),
),
(
"ProviderIcon-cursor",
include_bytes!("icons/ProviderIcon-cursor.svg"),
Expand Down
3 changes: 0 additions & 3 deletions rust/src/cli/serve/dashboard/icons/ProviderIcon-crof.svg
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions rust/src/core/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ pub enum ProviderId {
MiMo,
Doubao,
CommandCode,
Crof,
StepFun,
Venice,
OpenAIApi,
Expand Down Expand Up @@ -139,7 +138,6 @@ impl ProviderId {
ProviderId::MiMo,
ProviderId::Doubao,
ProviderId::CommandCode,
ProviderId::Crof,
ProviderId::StepFun,
ProviderId::Venice,
ProviderId::OpenAIApi,
Expand Down Expand Up @@ -226,7 +224,6 @@ impl ProviderId {
ProviderId::MiMo => "mimo",
ProviderId::Doubao => "doubao",
ProviderId::CommandCode => "commandcode",
ProviderId::Crof => "crof",
ProviderId::StepFun => "stepfun",
ProviderId::Venice => "venice",
ProviderId::OpenAIApi => "openaiapi",
Expand Down Expand Up @@ -310,7 +307,6 @@ impl ProviderId {
ProviderId::MiMo => "Xiaomi MiMo",
ProviderId::Doubao => "Doubao",
ProviderId::CommandCode => "Command Code",
ProviderId::Crof => "Crof",
ProviderId::StepFun => "StepFun",
ProviderId::Venice => "Venice",
ProviderId::OpenAIApi => "OpenAI API",
Expand Down Expand Up @@ -406,7 +402,6 @@ impl ProviderId {
ProviderId::AiAnd => None,
ProviderId::Windsurf => None,
ProviderId::Doubao => None,
ProviderId::Crof => None,
ProviderId::StepFun => None,
ProviderId::OpenAIApi => None,
ProviderId::ElevenLabs => None,
Expand Down Expand Up @@ -490,7 +485,6 @@ impl ProviderId {
}
"doubao" | "ark" | "volcengine" => Some(ProviderId::Doubao),
"commandcode" | "command-code" | "command code" => Some(ProviderId::CommandCode),
"crof" => Some(ProviderId::Crof),
"stepfun" | "step-fun" | "step fun" => Some(ProviderId::StepFun),
"venice" => Some(ProviderId::Venice),
"openaiapi" | "openai-api" | "openai api" | "openai-balance" => {
Expand Down Expand Up @@ -1048,7 +1042,6 @@ pub fn brand_color(id: ProviderId) -> &'static str {
ProviderId::MiMo => "#FF6900",
ProviderId::Doubao => "#2563EB",
ProviderId::CommandCode => "#44FF00",
ProviderId::Crof => "#7C3AED",
ProviderId::StepFun => "#999999",
ProviderId::Venice => "#111827",
ProviderId::OpenAIApi => "#10A37F",
Expand Down Expand Up @@ -1096,7 +1089,7 @@ mod tests {
#[test]
fn test_provider_id_all() {
let all = ProviderId::all();
assert_eq!(all.len(), 77);
assert_eq!(all.len(), 76);
assert!(all.contains(&ProviderId::Claude));
assert!(all.contains(&ProviderId::Codex));
assert!(all.contains(&ProviderId::Pi));
Expand All @@ -1121,7 +1114,6 @@ mod tests {
assert!(all.contains(&ProviderId::MiMo));
assert!(all.contains(&ProviderId::Doubao));
assert!(all.contains(&ProviderId::CommandCode));
assert!(all.contains(&ProviderId::Crof));
assert!(all.contains(&ProviderId::StepFun));
assert!(all.contains(&ProviderId::Venice));
assert!(all.contains(&ProviderId::OpenAIApi));
Expand Down Expand Up @@ -1231,6 +1223,7 @@ mod tests {
Some(ProviderId::Antigravity)
);
assert_eq!(ProviderId::from_cli_name("zed"), Some(ProviderId::Zed));
assert_eq!(ProviderId::from_cli_name("crof"), None);
assert_eq!(ProviderId::from_cli_name("unknown"), None);
assert_eq!(
ProviderId::from_cli_name("code-rabbit"),
Expand Down
17 changes: 8 additions & 9 deletions rust/src/core/provider_factory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ use crate::providers::{
AbacusProvider, AiAndProvider, AlibabaProvider, AlibabaTokenPlanProvider, AmpProvider,
AntigravityProvider, AugmentProvider, AzureOpenAIProvider, BedrockProvider, ChutesProvider,
ClaudeProvider, ClinePassProvider, CodeBuddyProvider, CodeRabbitProvider, CodebuffProvider,
CodexProvider, CommandCodeProvider, CopilotProvider, CrofProvider, CrossModelProvider,
CursorProvider, DeepInfraProvider, DeepSeekProvider, DeepgramProvider, DevinProvider,
DoubaoProvider, ElevenLabsProvider, FactoryProvider, FireworksProvider, GeminiProvider,
GrokProvider, GroqProvider, HuggingFaceProvider, InfiniProvider, JetBrainsProvider,
KiloProvider, KimiK2Provider, KimiProvider, KiroProvider, LLMProxyProvider, LiteLLMProvider,
LongCatProvider, ManusProvider, MetaProvider, MiMoProvider, MiniMaxProvider, MistralProvider,
MuseProvider, NanoGPTProvider, NeuralwattProvider, NotionProvider, NousProvider,
OllamaProvider, OpenAIApiProvider, OpenCodeGoProvider, OpenCodeProvider, OpenRouterProvider,
CodexProvider, CommandCodeProvider, CopilotProvider, CrossModelProvider, CursorProvider,
DeepInfraProvider, DeepSeekProvider, DeepgramProvider, DevinProvider, DoubaoProvider,
ElevenLabsProvider, FactoryProvider, FireworksProvider, GeminiProvider, GrokProvider,
GroqProvider, HuggingFaceProvider, InfiniProvider, JetBrainsProvider, KiloProvider,
KimiK2Provider, KimiProvider, KiroProvider, LLMProxyProvider, LiteLLMProvider, LongCatProvider,
ManusProvider, MetaProvider, MiMoProvider, MiniMaxProvider, MistralProvider, MuseProvider,
NanoGPTProvider, NeuralwattProvider, NotionProvider, NousProvider, OllamaProvider,
OpenAIApiProvider, OpenCodeGoProvider, OpenCodeProvider, OpenRouterProvider,
PerplexityProvider, PiProvider, PoeProvider, QoderProvider, QwenCloudProvider,
ReplicateProvider, SakanaProvider, StepFunProvider, Sub2ApiProvider, T3ChatProvider,
VeniceProvider, VertexAIProvider, WarpProvider, WayfinderProvider, WindsurfProvider,
Expand Down Expand Up @@ -73,7 +73,6 @@ pub fn instantiate(id: ProviderId) -> Box<dyn Provider> {
ProviderId::MiMo => Box::new(MiMoProvider::new()),
ProviderId::Doubao => Box::new(DoubaoProvider::new()),
ProviderId::CommandCode => Box::new(CommandCodeProvider::new()),
ProviderId::Crof => Box::new(CrofProvider::new()),
ProviderId::StepFun => Box::new(StepFunProvider::new()),
ProviderId::Venice => Box::new(VeniceProvider::new()),
ProviderId::OpenAIApi => Box::new(OpenAIApiProvider::new()),
Expand Down
1 change: 0 additions & 1 deletion rust/src/core/token_accounts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,6 @@ impl TokenAccountSupport {
| ProviderId::DeepSeek
| ProviderId::Windsurf
| ProviderId::Doubao
| ProviderId::Crof
| ProviderId::StepFun
| ProviderId::Venice
| ProviderId::OpenAIApi
Expand Down
Loading