Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds Chrome Beta, Dev, Canary, Chrome for Testing, and Chromium as distinct browser import sources. It resolves their profile paths, includes them in Windows browser detection, assigns import keys, and updates browser lists in the documentation. ChangesBrowser Import Sources
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WslBrowserDetector
participant windows_browser_candidates
participant BrowserType
participant user_data_dir_under
participant Filesystem
WslBrowserDetector->>windows_browser_candidates: Build browser candidates
windows_browser_candidates->>BrowserType: Iterate over all browser types
windows_browser_candidates->>user_data_dir_under: Resolve profile paths
windows_browser_candidates-->>WslBrowserDetector: Return candidate paths and browser types
WslBrowserDetector->>Filesystem: Check candidate directories for profiles
Merge Risk: ⚪ Minimal · up to No specific merge-blocking issue is established by the supplied evidence; complete normal checks before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for the PR, I will review it ASAP. |
|
Thanks! |
Summary
Not everyone uses the stable Chrome release, so I thought it would be useful to support the other Chrome channels too.
Related issue
Fixes #613
Affected areas
Validation
cargo fmt --all -- --checkgit diff --check b585d4887499c6b62d3a9ce7c22444e4bd283961...HEADrust/src/providers/muse/local_usage/cache.rsbecause it uses Windows-only APIs.UI / tray proof
Notes for reviewers
Please review that all six requested User Data roots map to distinct browser choices, while existing Chrome and Edge behavior remains unchanged.
Summary by CodeRabbit