Document the client local metrics endpoint - #952
Open
lixmal wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8 tasks
Contributor
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the client-side Prometheus
/metricsendpoint added in netbirdio/netbird#6689.New page Client → Local Metrics Endpoint (
/client/local-metrics):netbird up --enable-local-metricsand--local-metrics-address, and that the setting is per profileAlso:
dashboards.mdx: adds the client Grafana dashboard alongside management/signal/relay, its template variables, and a note that it scrapes clients rather than a server componentmdm-integration.mdx: adds theenableLocalMetricsandlocalMetricsAddresskeys, plus a note on how an MDM-pushed address relates to the privilege check. Corrects the key count, which was already stale at 16 against an 18-row tablemanage/client-metrics.mdx: links to the new page from the metrics-push docs, since both surface the same underlying client metrics