Repository navigation
Fixes #10: Fix recovery from stale running jobs during migration cutover - #47
Merged
jnovinger merged 1 commit intoOct 20, 2026
Conversation
pheus
marked this pull request as ready for review
October 15, 2026 16:47
jnovinger
previously approved these changes
Oct 16, 2026
jnovinger
left a comment
jnovinger
left a comment
Member
There was a problem hiding this comment.
The ternary at cutover.py:497 also turns a deleted row on an executed entry into executed instead of vanished, but the new tests only drive the running case. Did you want a test pinning that one too?
Collaborator
Author
|
Thanks! The two |
pheus
force-pushed
the
10-a-stale-running-job-blocks-migration-cutover-after-its-worker-stops
branch
from
October 20, 2026 15:41
e889447 to
558ce13
Compare
Record captured running jobs before refusing cutover and preserve their execution state after deletion so the reference pass does not replay them. Add regression tests and document stale-job recovery, with pointers from cutover messages to the migration guide. Fixes #10
pheus
force-pushed
the
10-a-stale-running-job-blocks-migration-cutover-after-its-worker-stops
branch
from
October 20, 2026 18:12
558ce13 to
27673cd
Compare
jnovinger
approved these changes
Oct 20, 2026
jnovinger
deleted the
10-a-stale-running-job-blocks-migration-cutover-after-its-worker-stops
branch
October 20, 2026 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10
Preserves the execution state of captured running Jobs so deleting a confirmed stale Job does not cause the reference pass to replay it.
Adds regression tests and documents how to recover when a stale Job blocks migration cutover, with pointers from cutover messages to the migration guide.