Repository navigation
Fixes #6: Read Data Source directories in one query - #51
Merged
jnovinger merged 1 commit intoOct 21, 2026
Merged
Conversation
Reads a Data Source directory's paths and bytes in one query scoped by the data path, replacing the separate path and content queries. Adds tests for a write during the read, the single query and a recurring Data Source, and documents NetBox's partial synchronizations. Fixes #6
pheus
marked this pull request as ready for review
October 21, 2026 18:46
jnovinger
approved these changes
Oct 21, 2026
jnovinger
deleted the
6-reconciliation-during-synchronization-can-stage-a-mixed
branch
October 21, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6
Read each Data Source directory's paths and contents in one query, scoped to the Project's data path. This prevents reconciliation from combining an earlier path inventory with newer file contents.
Add regression coverage for changes during the read, query count, directory scoping and reconciliation after recurring synchronizations. Update the documentation to describe the remaining synchronization limitation.
NetBox can still expose partially applied synchronizations. The core change to publish file updates atomically is tracked in netbox-community/netbox#23464.