Skip to content

fix(guide): judge auto-updates by the version, not the exit code #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CybotTM merged 7 commits into from
Sep 22, 2026
Merged

fix(guide): judge auto-updates by the version, not the exit code #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e59467c
fix(guide): judge auto-updates by the version, not the exit code
CybotTM Sep 21, 2026
2474d63
fix(guide): no auto-pin, confirmed held-back, no stale markers
CybotTM Sep 21, 2026
dc09c5b
fix(guide): hide a pinned tool only while its pin applies
CybotTM Sep 21, 2026
ed934c4
fix(guide): locale-proof held-back check, unverified verdict, venv-fr…
CybotTM Sep 21, 2026
ea172d8
fix(guide): decide shadowing by package ownership, not version strings
CybotTM Sep 21, 2026
128b395
fix(guide): parse dpkg -S output shapes for the held-back owner check
CybotTM Sep 21, 2026
4f320aa
test(guide): pin the dpkg path cut; state the owner-lookup order exactly
CybotTM Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ and the project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.
- Binary-probe fallback in `guide.sh` when the post-install snapshot refresh is stale.

### Fixed
- `make upgrade` hid every pinned tool, whatever the pin. A release skipped with `s` ("ask again when newer patch available") hid the tool for good. A pin now hides a tool only while it is `never`, equals the target release (`s`), equals the installed version (`p`), or equals the cycle.
- `make upgrade` auto-update no longer reports an upgrade as "Updated" just because the install script exited 0. The version is compared after the re-audit, the same check the interactive `Y`/`a` answers use; an unchanged version counts as "Failed" with the old and target version. A package manager without a newer package (`bwrap` on apt) and a binary identical to the target release with a stale version string (`sd` 1.1.0 reports 1.0.0) count as "Skipped". "Held back" requires the install command to succeed and, for apt, the installed package to be the candidate and to own the binary found on PATH; otherwise the unchanged version counts as "Failed". Without an upstream version the result is reported as unverified ("Skipped").
- difftastic 0.71.0 puts the version into its release file names (`difft-0.71.0-x86_64-unknown-linux-gnu.tar.gz`); the catalog download URL now includes it. byobu is tagged `trustmux-v7.19` since the trustmux rename, and those tags fill the first page of the tags API, so the installer found no stable tag; it now accepts both tag forms.
- `cmd_update_local` in MERGE mode now refreshes multi-version cycle entries (`python@3.14`, …) instead of only the base-tool entry. Resolved false-negative "Upgrade did not succeed" messages after successful uv installs.

Expand Down
Loading
Loading