fix(scripts): say "not found on PATH", not "not installed" - #161
Conversation
A shell's "command not found" means the name did not resolve on PATH; the tool may still be installed elsewhere or hidden by a stale hash. The hook's advice already tells the model to check `type -P -a` and `hash -r` first, but opened by asserting the opposite. A live run with the installed plugin flagged exactly that: the model noted the claim was not supported, since PATH had been emptied on purpose. The advice now states what the hook knows. The new test fails against the previous wording. Assisted-by: claude-code:claude-opus-5-5 Agent-Session: https://claude.ai/code/session_01NxSeVq1hDnGBCqKLGcjQ6m Agent-Host: 32116e Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Review before mergeCodeRabbit refused this head as rate limited and Copilot is out of quota, so the review of |
|
Self-review: 6bae2ed The bot review this pull request demands is unsatisfiable (Copilot quota wall or repeated bot failures on this head). The diff on this head was reviewed by the PR author; this comment is the on-the-record attestation the merge gate reads back. It stops matching on the next push. |
Merging this makes the
cli-toolshook say what it actually knows. For acommand not found, it now says the name "was not found on PATH" instead of claiming the tool "is not installed". The advice after that (checktype -P -aandhash -rfirst, then install) is unchanged.The installed plugin was run live in a fresh session, and the model receiving the hook's context pointed out that "not installed" was not supported by the evidence: PATH had been emptied on purpose, and
rgis installed. A shell only reports that a name did not resolve. The new test pins the wording and fails against the previous version.tests/test_detect_missing_tool.pypasses (20 passed, 1 skipped where zsh is absent).Assisted by claude-code:claude-opus-5-5 — Session
https://claude.ai/code/session_01NxSeVq1hDnGBCqKLGcjQ6m