Conversation
|
Thanks for this! The parser change is exactly right, and adding SummitIG to the README was a good catch — it should have been there already. I pulled the branch and checked the new fixture against the email: the same 12:00 AM–6:00 AM window read as UTC gives your 1740096000 / 1740117600, which is correct. Full suite passes for me too. One thing to fix before I merge: tests/unit/data/summitig/summitig_utc_result.json was added, but nothing references it — test_e2e.py doesn't have an entry for the new email, so it never gets loaded. And because nothing loads it, a missing comma after "end": 1740117600 went unnoticed (the file isn't valid JSON as it stands). Adding the comma and dropping this in next to the existing SummitIG entry around test_e2e.py:856 should do it: ( That gets the UTC email covered end to end, not just at the parser layer. One other note, just so you're not working around a problem that isn't there: I ran the full unit suite on current develop and got 419 passed, 0 failures. So the failures you saw look like something local rather than a broken baseline — poetry install --sync usually sorts it out if the virtualenv has drifted. Ping me once the fixture is wired up and I'll get this merged. |
|
Thanks for catching that! I fixed the json file and updated the test_e2e.py file with the requested changes: |
Added UTC as a valid timezone for the summitig parser and updated tests to validate the behavior.
NOTE: There are some failing unit tests for other parsers, however I validated they were already failing on the
developbranch so that should be unrelated to my changes.