Repository navigation
[stable29] fix(azure): clear libxml errors after parsing error responses - #2732
Merged
Merged
Conversation
ServiceException::parseErrorMessage() enables libxml's internal errors, but only restores the previous setting when the body parses, and never clears the errors. Newer libxml2 versions (e.g. 2.15 on Ubuntu 26.04) record "Document is empty" for the empty body of a 404 response to a HEAD or GET request, so that error stays in the buffer. sabre/xml reads the buffer after parsing, so every later parse in the same request or CLI process failed with a LibXMLException, even for valid XML such as the PROPFIND response of a WebDAV storage or a federated share. The upstream repository is archived, so the fix is applied as a patch. Upstream report: Azure/azure-storage-common-php#9 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
backport/2731/stable29
branch
from
November 19, 2026 09:19
878061f to
ea67570
Compare
DerDreschner
marked this pull request as ready for review
November 19, 2026 09:19
DerDreschner
approved these changes
Nov 19, 2026
Member
|
/server-pr |
Merged
1 task
Contributor
Signed-off-by: Joas Schilling <coding@schilljs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2731
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.