Skip to content

fix(webdav): handle percent-encoding case in DAV hrefs - #2191

Open
is-northfish wants to merge 2 commits into
nextcloud:masterfrom
is-northfish:fix/dav-percent-encoding-case
Open

is-northfish wants to merge 2 commits into
nextcloud:masterfrom
is-northfish:fix/dav-percent-encoding-case

Conversation

@is-northfish

Copy link
Copy Markdown

Compare DAV base paths literally after normalizing percent-encoded hex digits. Preserve the original relative path and reject missing or empty bases explicitly.

Fixes #2190

Assisted-by: Codex:GPT-6

All 71 unit tests passed. The array index out-of-bounds exception was reproduced with the original code.

  1. Compilation, detekt, and formatting checks passed.
  2. Lint passed after temporarily adding a missing dependency checksum verified against the official source. This adjustment is not included in the patch.
  3. The integration test compiled successfully but has not yet been run against an isolated test server.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

is-northfish and others added 2 commits October 30, 2026 12:52
Compare DAV base paths literally after normalizing percent-encoded hex digits.
Preserve the original relative path and reject missing or empty bases explicitly.

Fixes nextcloud#2190

Assisted-by: Codex:GPT-6
Signed-off-by: Gentle <5901220123@xcu.edu.cn>
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebdavEntry crashes on percent-encoding hex-case mismatch in DAV href for non-ASCII user IDs

1 participant