Skip to content

feat(open-file): remove syncing dialog - #17725

Draft
alperozturk96 wants to merge 11 commits into
masterfrom
feat/remove-retrieve-last-version
Draft

feat(open-file): remove syncing dialog#17725
alperozturk96 wants to merge 11 commits into
masterfrom
feat/remove-retrieve-last-version

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Implements: #17574

🏚️ Before Not Downloaded 🏡 After Not Downloaded
Screen_recording_20260928_134650.webm
Screen_recording_20260928_134322.webm
🏚️ Before Downloaded 🏡 After Downloaded
Screen_recording_20260928_134612.webm
Screen_recording_20260928_134253.webm

@alperozturk96 alperozturk96 linked an issue Sep 28, 2026 that may be closed by this pull request
Remove "retrieve last version" #17574
Open
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 9bf50de
Version 17725
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 19.58763% with 78 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...cloud/android/ui/helpers/FileOperationsHelper.java 0.00% 41 Missing ⚠️
...oud/android/operations/RefreshFolderOperation.java 28.57% 22 Missing and 3 partials ⚠️
...oud/android/operations/SynchronizeFileOperation.kt 0.00% 6 Missing ⚠️
...com/nextcloud/utils/extensions/OCFileExtensions.kt 0.00% 5 Missing ⚠️
...wncloud/android/ui/activity/FileDisplayActivity.kt 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

alperozturk96
alperozturk96 commented Oct 5, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java Outdated
@@ -318,7 +316,6 @@ public void openFile(OCFile file) {
final var sfo = new SynchronizeFileOperation(file,null, user, true, fileActivity, storageManager, false);

@alperozturk96 alperozturk96 Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check eTag if it's outdated then run SynchronizeFileOperation else skip.

alperozturk96
alperozturk96 commented Oct 5, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/operations/RefreshFolderOperation.java Outdated
updatedFile.setEncrypted(encrypted);
updatedFile.setReadOnly(localFile != null && localFile.isReadOnly());

if (!encrypted && OCFileExtensionsKt.isDownloadedFileChanged(localFile, remoteFile)) {

@alperozturk96 alperozturk96 Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only add when user open the folder first time not every 10 seconds.

@alperozturk96
alperozturk96 marked this pull request as draft October 5, 2026 09:39
@alperozturk96
alperozturk96 force-pushed the feat/remove-retrieve-last-version branch from e871f04 to d25e2b2 Compare October 5, 2026 10:02
@alperozturk96
add missing items for mFilesToSyncContents
806af82 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove sync in progress dialog
78ed942 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use kotlin durations
e62fcd9 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
reduce auto folder refresh to 10 seconds
a4cfa38 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the feat/remove-retrieve-last-version branch from d25e2b2 to a4cfa38 Compare October 5, 2026 10:02
@alperozturk96
Only add when user open the folder first time not every 10 seconds.
2f098c1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Check local eTag if it's outdated then run SynchronizeFileOperation e…
7adb65c 
…lse skip.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
simplify openFile function
9914ebd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix spotbugs: (This write of this shared primitive variable may not b…
225b806 
…e visible to other threads)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@nextcloud nextcloud deleted a comment from github-actions Bot Oct 5, 2026
@alperozturk96
simplify startContentSynchronizations
bb16d50 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
print results
95f666c 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
only sync when user get in directory
9bf50de 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96

alperozturk96 commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

If I try to open the .md file from file list, it triggers the public void startSyncForFileAndIntent(OCFile file, Intent intent) are we going to check that logic as well?

Because internally it still calls

private void syncFileOrFolder(OCFile file, User user, FileDataStorageManager storageManager) thus R.string.sync_in_progress will be shown.

Apparently openFile functions is not the only one. @tobiasKaminsky

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3030
Correctness5454
Dodgy code178178
Experimental11
Malicious code vulnerability22
Multithreaded correctness2621
Performance3535
Security1616
Total342337

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky
@daniele-verducci daniele-verducci Awaiting requested review from daniele-verducci

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

2. developing

Projects

None yet

Milestone

Nextcloud App 35.1.0

Development

Successfully merging this pull request may close these issues.

Remove "retrieve last version"

1 participant

@alperozturk96