improve unified share fetch - #17770
alperozturk96 wants to merge 2 commits into
Conversation
|
/backport to stable-35.0.x |
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
46bba3f to
fa42242
Compare
|
|
||
| private suspend fun ShareAvatarRepository.fetchSharees(file: OCFile) { | ||
| file.sharees = fetchShareAvatars(file.localId.toString())?.toAvatarSharees().orEmpty() | ||
| val shares = fetchShareAvatars(file.localId.toString()) ?: return |
There was a problem hiding this comment.
Should just return not with empty thus we don't override via false data
| } | ||
|
|
||
| if (newShares.isEmpty()) { | ||
| UnifiedShareSharees.fill(user, cachedFiles) |
There was a problem hiding this comment.
Adds missing call
…ground Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
daniele-verducci
left a comment
daniele-verducci
left a comment
There was a problem hiding this comment.
Hey Alper, it seems very good to me. I tested switching between a server with unified share and an old one and starting in airplane mode and then connecting to check the cache. Not sure how to test the sharees avatars null, but for the rest is perfect.
This branch has not been deployed
2 participants
Uh oh!
There was an error while loading. Please reload this page.