Skip to content

unify capabilities operations - #17969

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/get-capabilities
Nov 18, 2026
Merged

alperozturk96 merged 2 commits into
masterfrom
fix/get-capabilities

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

We are getting ANRs reports to get capabilities. Current logic uses cursor operations and hard to maintain, track code.

Changes

  • Uses DAO functions
  • In future we can use suspend function directly from DAO and get rid of all ANRs.

How to test?

  • Upgrade from 35.0.0, 34.0.0, 33.0.0, 3.31.0 to this branch

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.2.0 milestone Nov 5, 2026
@alperozturk96 alperozturk96 added 3. to review performance 🚀 Performance improvement opportunities (non-crash related) ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) AI assisted labels Nov 5, 2026
@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.08280% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...xtcloud/client/database/entity/CapabilityEntity.kt 91.15% 0 Missing and 13 partials ⚠️
...loud/android/datamodel/FileDataStorageManager.java 90.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 84a2eaf
Version 17969
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4646
Dodgy code118119
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2525
Security1515
Total243244

SpotBugs increased!

@alperozturk96
alperozturk96 merged commit e6fa06f into master Nov 18, 2026
24 of 27 checks passed
@alperozturk96
alperozturk96 deleted the fix/get-capabilities branch November 18, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted performance 🚀 Performance improvement opportunities (non-crash related) ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants