Skip to content

Don't show a new encryption passphrase when the setup screen is recreated. - #17981

Open
shivytyahoo wants to merge 1 commit into
nextcloud:masterfrom
shivytyahoo:fix/11571-encryption-passphrase-recreation
Open

shivytyahoo wants to merge 1 commit into
nextcloud:masterfrom
shivytyahoo:fix/11571-encryption-passphrase-recreation

Conversation

@shivytyahoo

@shivytyahoo shivytyahoo commented Nov 6, 2026 •

Copy link
Copy Markdown

Fixes #11571

The setup screen was showing a fresh dialog every time the activity was recreated, so the passphrase changed while you were copying it somewhere else.

Now it only shows the dialog the first time, and Android restores the one you already had after a rotation or when the app comes back.

The file list path already did it this way, this just does the same for the settings screen.

Screenshots

No visual change.

Checklist

  • Tests (unit and/or integration) are included or not needed — no test added: a recreation test for this activity needs a device/emulator and a server for the key download, I couldn't run that here. Happy to add one if you want it.
  • Backport requests are created or not needed: not needed
  • Milestone is set
  • PR title is meaningful

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@shivytyahoo
shivytyahoo force-pushed the fix/11571-encryption-passphrase-recreation branch from 0cf0ae2 to 171ab8f Compare November 6, 2026 11:34
The setup activity showed a fresh dialog on every recreation, so the
passphrase changed while the user was copying it somewhere else. Only
show the dialog the first time; Android restores the existing one with
its saved passphrase after rotation or when the app comes back.

Fixes nextcloud#11571

Signed-off-by: shivytyahoo <335833302+shivytyahoo@users.noreply.github.com>
@shivytyahoo
shivytyahoo force-pushed the fix/11571-encryption-passphrase-recreation branch from 171ab8f to fcaca1c Compare November 6, 2026 11:39
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encryption passphrase regenerates when you switch apps

1 participant