Skip to content

refactor(base-activity): kotlin - #18043

Merged
alperozturk96 merged 4 commits into
masterfrom
refactor/base-activity-kotlin
Nov 18, 2026
Merged

alperozturk96 merged 4 commits into
masterfrom
refactor/base-activity-kotlin

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Converts to Kotlin
  • Simplifies logic
  • Removes redundant theme setting calls

How to test?

  1. Fresh install login, use app
  2. Upgrade, use app
  3. Change theme

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.2.0 milestone Nov 12, 2026
@alperozturk96 alperozturk96 added 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 12, 2026
* Adapter delegating raw {@link SharedPreferences.OnSharedPreferenceChangeListener} calls with key-value pairs to
* respective {@link com.nextcloud.client.preferences.AppPreferences.Listener} method.
*/
static class ListenerRegistry implements SharedPreferences.OnSharedPreferenceChangeListener {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme listener don't need this.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 73b217e
Version 18043
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown

stable22-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/base-activity-kotlin branch from ed04dd2 to 73b217e Compare November 18, 2026 07:00
@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4646
Dodgy code118118
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2525
Security1515
Total243243

@alperozturk96
alperozturk96 merged commit 863802f into master Nov 18, 2026
25 checks passed
@alperozturk96
alperozturk96 deleted the refactor/base-activity-kotlin branch November 18, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants