Skip to content

fix(auth): simple sign up - #18058

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/auth-simple-sign-up
Nov 18, 2026
Merged

alperozturk96 merged 2 commits into
masterfrom
fix/auth-simple-sign-up

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes

  • Sign-up opens in the in-app WebView instead of showing "Invalid URL"
  • Back works inside the sign-up WebView on Android 13+
  • Login retry after rejected credentials now completes
  • Backgrounding the app no longer cancels the credentials check
  • Login resumes after the screen is recreated

How to test?

  1. Tap sign up
  2. Request for simple sign up
  3. Use new creds

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 1c3451b
Version 18058
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4646
Dodgy code118118
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2525
Security1515
Total243243

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 17.14286% with 87 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ud/android/authentication/AuthenticatorActivity.kt 16.84% 71 Missing and 8 partials ⚠️
...ndroid/authentication/signup/SignupWebViewLogin.kt 0.00% 7 Missing ⚠️
...uthentication/account/AuthenticatorAccountStore.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
alperozturk96 merged commit bf0e76f into master Nov 18, 2026
27 of 29 checks passed
@alperozturk96
alperozturk96 deleted the fix/auth-simple-sign-up branch November 18, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants