Repository navigation
refactor(upload-file-operation): local file transfers - #18084
Open
alperozturk96 wants to merge 6 commits into
Open
alperozturk96 wants to merge 6 commits into
alperozturk96 wants to merge 6 commits into
Conversation
alperozturk96
force-pushed
the
refactor/upload-file-operation-move-file-related-operation
branch
from
November 19, 2026 10:59
4ec0b10 to
a5a01fd
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…ileOperation Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…l tmp/ and points mFile at that copy. Neither the normal nor the encrypted upload path knew about it, so nothing ever deleted it, fixing via this Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
refactor/upload-file-operation-move-file-related-operation
branch
from
November 20, 2026 11:07
b3cf513 to
936ee6c
Compare
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/18084-IT-master-11-35 |
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
UploadFileOperation.javainto a new classUploadLocalFileTransfer.content://stream now returns an error instead of throwing aNullPointerException.internal files/nextcloud/tmp/, and it's now deleted when the upload finishes. It's kept on a conflict, because "Keep local" re-uploads from that path.How to test?