Skip to content

fix(auto-upload): dialog - #18089

Merged
alperozturk96 merged 3 commits into
masterfrom
fix/auto-upload-save-wrong-folder
Nov 20, 2026
Merged

alperozturk96 merged 3 commits into
masterfrom
fix/auto-upload-save-wrong-folder

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Settings are saved to the right folder even after configuration changes.
  • Saving no longer resets the "enabled since" time, so photos waiting to upload aren't skipped.
  • Turning a folder off in the dialog removes its pending uploads, the same as the list toggle.
  • Splits into smaller classes.
  • Fixes adapter update after hide folder, show hidden-folder etc.
  • Fixes overview screen updates after updating the configuration.

How to test?

  1. Auto upload → open "Configure" on a media folder that's off, turn it on, change a few options, Save.
  2. Open "Configure" on the same folder again, change an option, rotate the device, Save.
  3. The folder keeps its type and the saved values; no duplicate entry appears.

@github-actions

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit b67f186
Version 18089
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/auto-upload-save-wrong-folder branch from 9ac9dca to b67f186 Compare November 20, 2026 07:56
@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4545
Dodgy code119119
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2525
Security1515
Total243243

@alperozturk96 alperozturk96 added AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) performance 🚀 Performance improvement opportunities (non-crash related) 3. to review labels Nov 20, 2026
@alperozturk96
alperozturk96 merged commit a6c70d0 into master Nov 20, 2026
28 of 29 checks passed
@alperozturk96
alperozturk96 deleted the fix/auto-upload-save-wrong-folder branch November 20, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted performance 🚀 Performance improvement opportunities (non-crash related) ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auto upload does not stop uploading when disabling auto-upload for Camera

2 participants