Skip to content

fix(upload-files-activity): spinner npe - #18092

Open
alperozturk96 wants to merge 3 commits into
masterfrom
fix/upload-files-activity-spinner-npe
Open

alperozturk96 wants to merge 3 commits into
masterfrom
fix/upload-files-activity-spinner-npe

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

Issue

Exception java.lang.NullPointerException:
  at com.owncloud.android.ui.activity.UploadFilesActivity$setupToolbarSpinner$1.onItemSelected (UploadFilesActivity.kt:7)
  at android.widget.AdapterView.fireOnSelected (AdapterView.java:958)
  at android.widget.AdapterView.dispatchOnItemSelected (AdapterView.java:947)
  at android.widget.AdapterView.selectionChanged (AdapterView.java:936)
  at android.widget.AdapterView.checkSelectionChanged (AdapterView.java:1120)
  at android.widget.AdapterView.handleDataChanged (AdapterView.java:1096)
  at android.widget.AbsSpinner.onMeasure (AbsSpinner.java:193)
  at android.widget.Spinner.onMeasure (Spinner.java:618)
  at androidx.appcompat.widget.AppCompatSpinner.onMeasure (AppCompatSpinner.java:435)
  at android.view.View.measure (View.java:28708)
  at androidx.appcompat.widget.Toolbar.measureChildCollapseMargins (Toolbar.java:1792)
  at androidx.appcompat.widget.Toolbar.onMeasure (Toolbar.java:1900)
  at android.view.View.measure (View.java:28708)
  at android.widget.RelativeLayout.measureChildHorizontal (RelativeLayout.java:736)
  at android.widget.RelativeLayout.onMeasure (RelativeLayout.java:482)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:195)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.LinearLayout.measureChildBeforeLayout (LinearLayout.java:1609)
  at android.widget.LinearLayout.measureVertical (LinearLayout.java:879)
  at android.widget.LinearLayout.onMeasure (LinearLayout.java:722)
  at com.google.android.material.appbar.AppBarLayout.onMeasure (AppBarLayout.java:639)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.LinearLayout.measureChildBeforeLayout (LinearLayout.java:1609)
  at android.widget.LinearLayout.measureVertical (LinearLayout.java:879)
  at android.widget.LinearLayout.onMeasure (LinearLayout.java:722)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:195)
  at androidx.appcompat.widget.ContentFrameLayout.onMeasure (ContentFrameLayout.java:142)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:195)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:195)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.LinearLayout.measureChildBeforeLayout (LinearLayout.java:1609)
  at android.widget.LinearLayout.measureVertical (LinearLayout.java:879)
  at android.widget.LinearLayout.onMeasure (LinearLayout.java:722)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7173)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:195)
  at com.android.internal.policy.DecorView.onMeasure (DecorView.java:728)
  at android.view.View.measure (View.java:28708)
  at android.view.ViewRootImpl.performMeasure (ViewRootImpl.java:5559)
  at android.view.ViewRootImpl.measureHierarchy (ViewRootImpl.java:3720)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:4179)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:3386)
  at android.view.ViewRootImpl$TraversalCallback.onVsync (ViewRootImpl.java:11522)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1845)
  at android.view.Choreographer.doCallbacks (Choreographer.java:1387)
  at android.view.Choreographer.doFrame (Choreographer.java:1244)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1821)
  at android.os.Handler.handleCallback (Handler.java:1082)
  at android.os.Handler.dispatchMessageImpl (Handler.java:135)
  at android.os.Handler.dispatchMessage (Handler.java:126)
  at android.os.Looper.loopOnce (Looper.java:295)
  at android.os.Looper.loop (Looper.java:398)
  at android.app.ActivityThread.main (ActivityThread.java:9569)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:575)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:918)

Changes

  • Makes onItemSelected parameters nullable because listener can be called before the selected row view exists.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit e162784
Version 18092
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4545
Dodgy code119119
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2525
Security1515
Total243243

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant