Skip to content

chore: add PR template and coding conventions from mail - #5908

Merged
GVodyanov merged 2 commits into
mainfrom
chore/agents-conventions-pr-template
Nov 19, 2026
Merged

GVodyanov merged 2 commits into
mainfrom
chore/agents-conventions-pr-template

Conversation

@GVodyanov

@GVodyanov GVodyanov commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Context

No ticket. This brings over what nextcloud/mail already has: the PR template from nextcloud/mail#14204, plus the review conventions and ticket-readiness rules from mail's AGENTS.md.

Approach

  • PR template: same as mail. It asks for the reasoning (approach, alternatives, what was left out) instead of a description of the diff, and has no checklist. Manual testing mentions a CardDAV client instead of IMAP/JMAP. The first line says "for human reviewers" instead of "in your own words", to match the updated org AI policy (docs(ai-policy): allow AI-drafted text written for human readers .github#839).
  • AGENTS.md: adds the code comment rules, the coding conventions maintainers keep raising in review (PHP, mappers, migrations, performance, frontend, i18n, a11y), ticket readiness based on the pipeline labels (here 0. Needs triage), the good first issue rule, and where user and admin docs live. The CodeRabbit note is kept, since this repo has a .coderabbit.yaml.

Left out on purpose: mail-specific content (IMAP/Horde, Mozart, OpenAPI, TrapError, the mail gotchas section and the CONTRIBUTING link, which this repo doesn't have).

Merges cleanly with #5907, which touches the neighbouring sections.

Testing

Docs and template only, nothing to test at runtime. The template applies only to PRs opened after this merges.

AI assistance

Drafted with Claude Code.

Assisted by ClaudeCode:claude-opus-5-5

PR descriptions often restate the diff and leave out the reasoning.
The template asks for the approach, the alternatives considered and
what was left out on purpose, plus screenshots and manual testing
notes. It has no checklist, since those points are the contributor's
responsibility. Same template as nextcloud/mail.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Grigory V <scratchx@gmx.com>
These are the points maintainers keep raising in review across the
groupware apps. Writing them down lets agents follow them up front,
and the ticket-readiness rules stop agents from implementing features
nobody has triaged yet. Mail-specific parts were left out.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
GVodyanov marked this pull request as ready for review November 18, 2026 10:12
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 18, 2026
@GVodyanov
GVodyanov merged commit 3df27a8 into main Nov 19, 2026
37 of 38 checks passed
@GVodyanov
GVodyanov deleted the chore/agents-conventions-pr-template branch November 19, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants