fix(file-provider): Treat 404s on items intended for deletion as valid - #10771
Open
claucambra wants to merge 3 commits into
Open
claucambra wants to merge 3 commits into
claucambra wants to merge 3 commits into
Conversation
…h name comment Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Fixes #10737 Address any missing item that is meant to be deleted (including non-trashed items) as a successful deletion Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
claucambra
requested review from
camilasan,
i2h3 and
mgallien
as code owners
September 9, 2026 09:33
Collaborator
Author
|
/backport to stable-34.0 |
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10771.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
claucambra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#10737
Summary
An item that is ordered to be deleted locally but has already been deleted on the server can trigger permanent deletion attempts that will always fail with a 404
Allow these 404s to be treated as valid and complete deletions
Checklist
AI (if applicable)