Conversation
DmySyz
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
September 10, 2026 21:29
DmySyz
marked this pull request as draft
September 10, 2026 21:32
claucambra
requested changes
Sep 11, 2026
claucambra
left a comment
claucambra
left a comment
Collaborator
There was a problem hiding this comment.
Hi, looks like maybe there was some issue when rebasing the branch or something along these lines, there is a humongous changeset in this PR
DmySyz
force-pushed
the
fix/lock-timeout-zero-minutes-notification
branch
from
September 15, 2026 13:30
e7a0b4a to
9bd73c1
Compare
Contributor
Author
Yep, not sure what happened - should be ok now. |
DmySyz
marked this pull request as ready for review
September 16, 2026 07:42
DmySyz
force-pushed
the
fix/lock-timeout-zero-minutes-notification
branch
from
September 16, 2026 07:42
9bd73c1 to
0c2a0ff
Compare
|
When files_lock is configured with lock_timeout = -1 (default, infinite) or 0, the DAV nc:lock-timeout property returns a non-positive value. fileLockTimeRemainingMinutes() would compute a past expiry time, yield a negative remainingTime and return 0, causing the system tray notification to say "Lock will last for 0 minutes." Guard for lockTimeOut <= 0 and return -1 as a sentinel for "no expiry". Both fileAlreadyLocked() and fileLockSuccess() now check the sentinel and show "Lock has no expiry. You can unlock this file manually once you are finished editing." instead. Assisted-by: ClaudeCode:claude-sonnet-4-8 Signed-off-by: dsyzov <dmytro.syzov@nextcloud.com>
DmySyz
force-pushed
the
fix/lock-timeout-zero-minutes-notification
branch
from
September 16, 2026 10:06
0c2a0ff to
36d5d2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Summary
When "files_lock lock_timeout" parameter is set to “0,” the notification states that the file is locked indefinitely instead of saying that the file will be locked for "0 minutes".
Checklist
AI (if applicable)
Assisted-by: ClaudeCode:claude-sonnet-4-8