Repository navigation
fix(l10n): Use plural forms for the file and folder counts - #4477
Open
rakekniven wants to merge 1 commit into
Open
rakekniven wants to merge 1 commit into
rakekniven wants to merge 1 commit into
Conversation
The section footer and the trash joined a number with "file"/"files" or "folder"/"folders", which only works for languages with two plural forms. Use stringsdict plural rules instead and drop the four old keys. Reported at Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A translator asked at Transifex whether a number comes before "files". It does: the section footer of the file list and the trash join the count with
_file_/_files_and_folder_/_folders_("12 files • 3.4 MB"). The "1 vs. more than 1" check only works for languages with two plural forms; languages like Russian or Polish need more.This PR:
_files_count_("%ld file" / "%ld files") and_folders_count_("%ld folder" / "%ld folders") toen.lproj/Localizable.stringsdictString.localizedStringWithFormatinNCSectionFooter.swiftandNCTrash+CollectionView.swift_file_,_files_,_folder_,_folders_fromen.lproj/Localizable.stringsThe text stays the same in English. I could not build the app locally.
🤖 Generated with Claude Code