Skip to content

Add an experimental foldable layout for Direct Editing - #4478

Merged
marinofaggiana merged 16 commits into
masterfrom
prototype-text
Nov 20, 2026
Merged

marinofaggiana merged 16 commits into
masterfrom
prototype-text

Conversation

@marinofaggiana

@marinofaggiana marinofaggiana commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

This PR adds an adaptive layout for Direct Editing when iPhone Duo is folded. The editor stays in the upper pane, and a SwiftUI command bar provides Back, the filename, Favorite, and Details.

  • Share a fold separator between Direct Editing and the media viewer. Both adaptive layouts are disabled by default.
  • Stack Details and Favorite vertically in the Direct Editing overflow menu. Use the NextcloudKit tags API to update favorites while a document is locked for editing.
  • Allow file owners to unlock app-locked files from the context menu.
  • Extend media viewer test coverage to verify the separator’s placement and visibility when folding and unfolding.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Keep the text editor above the fold and keyboard on iOS 27.1, hide the keyboard accessory, and focus the editor when folded.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Switch folded layout constraints as groups, remove layout debug logging, and restore standard back navigation.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Remove keyboard visibility gating, wait for navigation to finish before requesting focus, and soften the fold decoration with a gradient.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Capture the viewer weakly, always complete the menu callback, and use the stored controller for context menu actions.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Extend the folded layout to all direct editors with back navigation, file names and favorite controls. Update favorites through NextcloudKit tags while preserving active metadata operations, and switch NextcloudKit to TAG_FAVORITE.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Improve filename sizing, label favorite actions consistently, and refresh the command bar styling. Switch NextcloudKit from TAG_FAVORITE to main.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Anchor the command bar above the fold and center its decoration independently within the fold region. Require enough space for the controls before enabling the folded layout.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Extract a reusable fold separator and add coverage for its media layout and visibility. Disable the experimental adaptive editor layout.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana marinofaggiana changed the title Prototype text Add an experimental foldable layout for Direct Editing Nov 19, 2026
@marinofaggiana
marinofaggiana merged commit 33c89be into master Nov 20, 2026
6 checks passed
@marinofaggiana
marinofaggiana deleted the prototype-text branch November 20, 2026 08:35
@marinofaggiana marinofaggiana self-assigned this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant