Repository navigation
Add an experimental foldable layout for Direct Editing - #4478
Merged
Merged
Conversation
Keep the text editor above the fold and keyboard on iOS 27.1, hide the keyboard accessory, and focus the editor when folded. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Switch folded layout constraints as groups, remove layout debug logging, and restore standard back navigation. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Remove keyboard visibility gating, wait for navigation to finish before requesting focus, and soften the fold decoration with a gradient. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Capture the viewer weakly, always complete the menu callback, and use the stored controller for context menu actions. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Extend the folded layout to all direct editors with back navigation, file names and favorite controls. Update favorites through NextcloudKit tags while preserving active metadata operations, and switch NextcloudKit to TAG_FAVORITE. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Improve filename sizing, label favorite actions consistently, and refresh the command bar styling. Switch NextcloudKit from TAG_FAVORITE to main. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Anchor the command bar above the fold and center its decoration independently within the fold region. Require enough space for the controls before enabling the folded layout. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Extract a reusable fold separator and add coverage for its media layout and visibility. Disable the experimental adaptive editor layout. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an adaptive layout for Direct Editing when iPhone Duo is folded. The editor stays in the upper pane, and a SwiftUI command bar provides Back, the filename, Favorite, and Details.
🤖 AI (if applicable)