Repository navigation
Fix: file search pagination and premature “No results” messages - #4480
Merged
marinofaggiana merged 2 commits intoNov 20, 2026
Conversation
Guard concurrent requests and discard results for replaced sections. Stop Files pagination when entries are empty or the cursor repeats, and refresh loading state on completion. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Track active searches by UUID to ignore outdated results and loading updates. Show no-results text only after the current query completes successfully. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
marinofaggiana
deleted the
4454-load-more-results-stays-visible-after-file-search-results-are-exhausted
branch
November 20, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Files section now hides Load more results when the server returns an empty page, repeats the cursor, or omits the next cursor. Previously loaded results remain visible.
Opening Search shows the search instructions. No results appears only after the current query completes successfully without matches. The client also prevents duplicate pagination requests and ignores responses from stale searches.
Closes #4454.
🤖 AI (if applicable)