Skip to content

Fix: file search pagination and premature “No results” messages - #4480

Merged
marinofaggiana merged 2 commits into
masterfrom
4454-load-more-results-stays-visible-after-file-search-results-are-exhausted
Nov 20, 2026
Merged

marinofaggiana merged 2 commits into
masterfrom
4454-load-more-results-stays-visible-after-file-search-results-are-exhausted

Conversation

@marinofaggiana

@marinofaggiana marinofaggiana commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

The Files section now hides Load more results when the server returns an empty page, repeats the cursor, or omits the next cursor. Previously loaded results remain visible.

Opening Search shows the search instructions. No results appears only after the current query completes successfully without matches. The client also prevents duplicate pagination requests and ignores responses from stale searches.

Closes #4454.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Guard concurrent requests and discard results for replaced sections. Stop Files pagination when entries are empty or the cursor repeats, and refresh loading state on completion.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Track active searches by UUID to ignore outdated results and loading updates. Show no-results text only after the current query completes successfully.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana marinofaggiana changed the title 4454 load more results stays visible after file search results are exhausted Fix file search pagination and premature “No results” messages Nov 20, 2026
@marinofaggiana marinofaggiana changed the title Fix file search pagination and premature “No results” messages Fix: file search pagination and premature “No results” messages Nov 20, 2026
@marinofaggiana
marinofaggiana merged commit 5fad5dd into master Nov 20, 2026
6 checks passed
@marinofaggiana
marinofaggiana deleted the 4454-load-more-results-stays-visible-after-file-search-results-are-exhausted branch November 20, 2026 09:38
@marinofaggiana marinofaggiana self-assigned this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

“Load more results” stays visible after file search results are exhausted

1 participant