Skip to content

Improve sync error handling - #3401

Merged
alperozturk96 merged 14 commits into
mainfrom
improve-sync-error-handling
Nov 20, 2026
Merged

alperozturk96 merged 14 commits into
mainfrom
improve-sync-error-handling

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

After the Files app was reinstalled, Notes couldn't sync anymore ("token mismatch")
The app said "server unreachable" instead of the real reason.
The only advice was "remove and add the account", which deletes unsynced notes.
Old errors kept popping up even after syncing worked again.


Synchronization failed error appears instead of account removed.

How to reproduce?

  1. Have a files app and notes app
  2. Reinstall or upgrade files app
  3. Open notes app
  4. Sync error and old error messages will appear

  1. Have a files app and notes app
  2. Login files app via two accounts
  3. Login notes app via same two accounts
  4. Remove first account from Files
  5. Open Notes app that uses first account error message will be just sync failed instead more meaningful message - also try pull to refresh after open the notes app

Changes

  • Shows better error messages.
  • Adds "Grant access" button: when Notes loses access, the error has a button that asks the Files app for access again.
  • Removes stale errors from previous session.

Demo

Screen_recording_20261120_113149.mp4

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codacy-production

codacy-production Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
ErrorProne 1 high

View in Codacy

🟢 Metrics 23 complexity · 0 duplication

Metric Results
Complexity 23
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 9a3fc12
Version 3401
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96
alperozturk96 force-pushed the improve-sync-error-handling branch from f9a1897 to ba2a894 Compare October 28, 2026 11:42
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the improve-sync-error-handling branch from ba2a894 to 3fdc17d Compare November 20, 2026 08:31
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the 35.1.0 milestone Nov 20, 2026

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine and fixed a problem I experimented myself in the past, so 💯

I'd make a slight change to the account removed string, but otherwise it can be merged!

Comment thread app/src/main/res/values/strings.xml Resolved
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 merged commit 8ef77e1 into main Nov 20, 2026
12 of 14 checks passed
@alperozturk96
alperozturk96 deleted the improve-sync-error-handling branch November 20, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants