Repository navigation
feat: let scoped app passwords read notifications and register for push - #3510
Conversation
Web push is used by mobile apps that don't use google play services. So should also be allowed |
Makes sense thanks, I didn’t know web push was used by apps 👍 Opened both web push and the personal settings route. |
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
… settings Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
16e4443 to
af9c99e
Compare
|
🐢 Performance warning. |
Part of nextcloud/server#65523
Note
Needs nextcloud/server#65340, which refuses app passwords limited to scopes on every route without a
#[TokenScope]. Until that is merged,nextcloud/ocpdoesn't have the attribute class, so psalm will complain.This stays in
Draftuntil then.Summary
Adds the
notifications:notifications:readscope to the notifications list, push registration (mobile and web push) and your own notification settings.Dismissing a notification and changing your own settings are also open under this scope. Both only touch your own account, so a separate write scope didn't seem worth an extra checkbox. Happy to be convinced otherwise.
Admin settings stay closed.
Manually tested:
The checkbox in Settings follows in server once this is merged.
AI