Skip to content

feat: let scoped app passwords read notifications and register for push - #3510

Merged
pringelmann merged 2 commits into
masterfrom
feat/noid/app-password-scope
Nov 19, 2026
Merged

pringelmann merged 2 commits into
masterfrom
feat/noid/app-password-scope

Conversation

@pringelmann

@pringelmann pringelmann commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Part of nextcloud/server#65523

Note

Needs nextcloud/server#65340, which refuses app passwords limited to scopes on every route without a #[TokenScope]. Until that is merged, nextcloud/ocp doesn't have the attribute class, so psalm will complain.
This stays in Draft until then.

Summary

Adds the notifications:notifications:read scope to the notifications list, push registration (mobile and web push) and your own notification settings.

Dismissing a notification and changing your own settings are also open under this scope. Both only touch your own account, so a separate write scope didn't seem worth an extra checkbox. Happy to be convinced otherwise.

Admin settings stay closed.

Manually tested:

  • A Files key gets 403 on the list, dismiss and push registration, and passes with the scope added.
  • Settings and web push stay 403.

The checkbox in Settings follows in server once this is merged.

AI

  • Partly generated with AI

@nickvergessen

nickvergessen commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Stays closed:

  • web push (browser only)

Web push is used by mobile apps that don't use google play services. So should also be allowed
I would also add the personal settings route if that is possible without the admin one, as we could allow clients to change that setting going forward.

@pringelmann

Copy link
Copy Markdown
Contributor Author

Stays closed:

  • web push (browser only)

Web push is used by mobile apps that don't use google play services. So should also be allowed I would also add the personal settings route if that is possible without the admin one, as we could allow clients to change that setting going forward.

Makes sense thanks, I didn’t know web push was used by apps 👍 Opened both web push and the personal settings route.

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
… settings

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann force-pushed the feat/noid/app-password-scope branch 2 times, most recently from 16e4443 to af9c99e Compare November 19, 2026 17:34
@github-actions

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9655 was 9158 (+5.42%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@pringelmann
pringelmann merged commit c71c46b into master Nov 19, 2026
41 checks passed
@pringelmann
pringelmann deleted the feat/noid/app-password-scope branch November 19, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants