feat: add new response type StreamTraversableResponse - #301
Conversation
|
Could add a sample into tests/ to see it works? |
|
LGTM, please add a test @Altahrim |
7a93d8d to
f8ec428
Compare
|
Added a line so the new method is tested, but it is failing |
provokateurin
left a comment
There was a problem hiding this comment.
The output looks wrong, there is no 200 response.
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
97c93af to
f761dce
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
f761dce to
c877b06
Compare
|
I fixed the errors and re-based. All checks now pass |
What's "missing" is just the response body (no content/schema under 200). That's correct, not a bug: StreamTraversableResponse has no type template in the real OCP class (only status + headers), so the extractor has no schema to emit — same as StreamGeneratorResponse, which is defined identically in ResponseType.php:130-137 (content type null, type null). A streamed/traversable response can yield arbitrary content, so there's no fixed schema to describe. |
Introduced by nextcloud/server#57165