Skip to content

feat: add new response type StreamTraversableResponse - #301

Merged
SebastianKrupinski merged 3 commits into
mainfrom
feat/stream_traversable
Aug 19, 2026
Merged

feat: add new response type StreamTraversableResponse#301
SebastianKrupinski merged 3 commits into
mainfrom
feat/stream_traversable

Conversation

@Altahrim

Copy link
Copy Markdown
Contributor

Introduced by nextcloud/server#57165

@Altahrim Altahrim self-assigned this Dec 18, 2025
@Altahrim Altahrim added the enhancement New feature or request label Dec 18, 2025
@nickvergessen

Copy link
Copy Markdown
Member

Could add a sample into tests/ to see it works?

@provokateurin

Copy link
Copy Markdown
Member

LGTM, please add a test @Altahrim

@Altahrim
Altahrim force-pushed the feat/stream_traversable branch from 7a93d8d to f8ec428 Compare January 30, 2026 08:57
@nickvergessen

Copy link
Copy Markdown
Member

Added a line so the new method is tested, but it is failing

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output looks wrong, there is no 200 response.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

I fixed the errors and re-based. All checks now pass

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

The output looks wrong, there is no 200 response.

What's "missing" is just the response body (no content/schema under 200). That's correct, not a bug: StreamTraversableResponse has no type template in the real OCP class (only status + headers), so the extractor has no schema to emit — same as StreamGeneratorResponse, which is defined identically in ResponseType.php:130-137 (content type null, type null). A streamed/traversable response can yield arbitrary content, so there's no fixed schema to describe.

@SebastianKrupinski
SebastianKrupinski merged commit 5d01d44 into main Aug 19, 2026
30 checks passed
@SebastianKrupinski
SebastianKrupinski deleted the feat/stream_traversable branch August 19, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants