fix(jobs): resolve portability issues with background job cleanup#61830
Open
stklcode wants to merge 2 commits into
Open
fix(jobs): resolve portability issues with background job cleanup#61830stklcode wants to merge 2 commits into
stklcode wants to merge 2 commits into
Conversation
stklcode
requested review from
come-nc,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
Altahrim
approved these changes
Jul 6, 2026
Altahrim
left a comment
Altahrim
left a comment
Collaborator
There was a problem hiding this comment.
Nice improvement, thank you!
(and yes… remaining test thank you for catching it!)
come-nc
approved these changes
Jul 6, 2026
The previous implementation executes "ps" with flags -p and -o to check whether a job process was still running. This approach has portability issues regarding e.g. BusyBox ps (Alpine Linux) where `ps -p` fails or BSD/macOS where `ps -o` fails. Replace with `posix_kill($pid, 0)`, the standard POSIX way to probe process existence without delivering a signal. EPERM is treated as "process exists but not owned by current user". This should be available on all supported platforms. Fixes: 60ce92a Suggested-by: Michele Marcionelli Signed-off-by: Stefan Kalscheuer <stefan@stklcode.de>
Snowflake ID in `JobRuns:deleteBefore()` is computed from given timestamp, but immediately overwritten by a literal value making the expiration setting have no effect. This looks like a leftover artifact from development that should be cleaned up. Remove the hardcoded ID to restore the desired behavior. Fixes: dc5499a Suggested-by: Michele Marcionelli Signed-off-by: Stefan Kalscheuer <stefan@stklcode.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
background_jobs_expiration_daysis ignored #61635Summary
This PR resolves two issues with background job cleanup introduced recently:
Portability of cleanup on Alpine, BSD and macOS
The previous implementation executes "ps" with flags -p and -o to check whether a job process was still running. This approach has portability issues regarding e.g.
ps -pfails(this affects the official "fpm-alpine" Docker image)
ps -ofailsReplace with
posix_kill($pid, 0), the standard POSIX way to probe process existence without delivering a signal.EPERMis treated as "process exists but not owned by current user". This should be available on all supported platforms.Hardcoded snowflake ID prevents
background_jobs_expiration_daysSnowflake ID in
JobRuns:deleteBefore()is computed from given timestamp, but immediately overwritten by a literal value making the expiration setting have no effect.This looks like a leftover artifact from development that should be cleaned up. Remove the hardcoded ID to restore the desired behavior.
Both fixes suggested by @mmdevl in the linked issue.
Checklist
3. to review, feature component)stable32)AI (if applicable)