Skip to content

fix(DeclarativeManager): Fix admin delegation#61845

Merged
AndyScherzinger merged 2 commits into
masterfrom
fix/declarative-settings-delegation
Jul 7, 2026
Merged

fix(DeclarativeManager): Fix admin delegation#61845
AndyScherzinger merged 2 commits into
masterfrom
fix/declarative-settings-delegation

Conversation

@marcelklehr

@marcelklehr marcelklehr commented Jul 6, 2026

Copy link
Copy Markdown
Member

The bug

  • As admin, go to Settings → Admin Delegation
  • Assign a group the following delegated sections: Basic Settings → Background Jobs and Basic Settings → Email Server
  • Log in as a non-admin user who is a member of that group
  • The navigation item "Basic Settings" appears in the admin menu

Expected behavior:

  • The user can access the delegated admin sections.

Actual behavior:

  • Navigating to /settings/admin returns "Access Denied". The navigation entry is rendered but the route does not grant access based on delegation permissions.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr added this to the Nextcloud 35 milestone Jul 6, 2026
@marcelklehr marcelklehr requested a review from a team as a code owner July 6, 2026 13:19
@marcelklehr marcelklehr requested review from come-nc, leftybournes, provokateurin and salmart-dev and removed request for a team July 6, 2026 13:19
@marcelklehr

Copy link
Copy Markdown
Member Author

/backport to stable34

@marcelklehr

Copy link
Copy Markdown
Member Author

/backport to stable33

@marcelklehr

Copy link
Copy Markdown
Member Author

/backport to stable32

@marcelklehr marcelklehr self-assigned this Jul 6, 2026

@come-nc come-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this fixing?

@marcelklehr

Copy link
Copy Markdown
Member Author

Sorry, I added reproduction steps above.

@marcelklehr marcelklehr requested a review from come-nc July 6, 2026 18:53
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

@come-nc come-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declarative settings are incompatible with delegated settings and this PR correctly applies this restriction.
It would be a better fix to make them compatible but it’s a way bigger change.

Let’s get this in as it fixes access to other settings when some settings only are declarative ones.

@AndyScherzinger AndyScherzinger merged commit 39d2dc2 into master Jul 7, 2026
193 of 196 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/declarative-settings-delegation branch July 7, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants