feat(core): header-anchored combobox shell for unified search#61849
Draft
pringelmann wants to merge 2 commits into
Draft
feat(core): header-anchored combobox shell for unified search#61849pringelmann wants to merge 2 commits into
pringelmann wants to merge 2 commits into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
f3b2846 to
aa0153e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the header search into the a combobox shell. The header field is now a real combobox
<input>: you type into directly, and results show in a popover anchored under it instead of a centredNcDialog. Mobile collapses to a button that opens a full-height panel with anNcTextFieldinside.The popover opens on the first character and closes when cleared (Ctrl+F opens it empty). Focusing the empty field doesn't open the popover.
Not in this PR: the search orchestration bugs (result flashing, no request cancellation, "load more") go to subtask 5, and the full combobox keyboard/a11y model goes to subtask 6. The shell just wires the input to the existing search results.
Why custom, not NC components:
#headeris its own stacking context and NcModal teleports tobody, so it can't sit below the in-header input while dimming the page (and it steals focus off the input). The input is a plain<input>because NcTextField assumes a light form background + floating label that clash with the themed header.focus-trapis already a dep and the panel reuses NcModal's exact styling so it still looks like a standard dialog. Mobile stays a plainsearchboxon purpose.TODO
Checklist
AI