perf(files_sharing): simplify tag population in ShareAPIController#61853
Draft
joshtrichards wants to merge 3 commits into
Draft
perf(files_sharing): simplify tag population in ShareAPIController#61853joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
joshtrichards
added
enhancement
2. developing
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/perf-sharing-populateTags
branch
from
bfed23e to
0fd8479
Compare
Adjust the Psalm docblock for populateTags() to reflect the internal implementation change without changing the returned data shape. Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build an index in
ShareAPIController::populateTags()instead of scanning the full result list for each tagged file.Notes
Multiple formatted share entries can refer to the same
file_source, so the index keeps all matching positions.Checklist
3. to review, feature component)stable32)AI (if applicable)